Stumbled into a code review at a local meetup back in 2019 that changed how I write comments

I was at this small meetup in Austin and someone pulled up my pull request on the big screen. They pointed out I was explaining WHAT the code did instead of WHY it was done that way. Has anyone else had a similar moment where a small habit got completely flipped?

3 comments

3 Comments

amyh1210d ago

Heard the SAME thing from my buddy Mark after his first code review at a startup. He used to write "this loops through the array" and got told "no duh, tell me WHY the array matters." Completely changed how he writes everything now.

gracethomas10d ago

Funny how one code review can totally rewrire your brain, right?

amyh1210d ago

Oh and I'd add that sometimes the reviewer is wrong though. I had a guy tell me to rename a variable to "x" and I'm pretty sure he just hated reading code that day.